Ticket Navigation

Ticket #860 (defect)

Opened 2 years ago

Last modified 1 year ago

Robustness issue in exception catching

Status: closed (fixed)

Reported by:	olivier.aubert@liris.cnrs.fr	Assigned to:	fumanchu
Priority:	normal	Milestone:	3.0
Component:	wsgiserver	Keywords:
Cc:

In wsgiserver.tick(), there is a selective exception catching clause:

        except socket.error, x:
            msg = x.args[1]
            if msg in ("Bad file descriptor", "Socket operation on non-socket"):
                # Our socket was closed.
                return
            if msg == "Resource temporarily unavailable":
                # Just try again. See http://www.cherrypy.org/ticket/479.
                return
            raise

Problem arises when cherrypy is used with a locale other than C/english: error messages do not match. The error code (i.e. x.args[0]) should be used instead.

Change History

09/27/08 14:50:07: Modified by fumanchu

status changed from new to assigned.
description changed.
milestone set to 3.1.

Reformatted.

09/27/08 15:05:41: Modified by fumanchu

milestone changed from 3.1 to 3.0.

This was fixed in [1937] for 3.1. Does it need a backport to 3.0.x?

04/01/09 11:10:53: Modified by klarson

status changed from assigned to closed.
resolution set to fixed.

Backported in 3.0 [2230].