Download Install Tutorial Docs FAQ Tools WikiLicense Team IRC Planet Involvement Shop Book

Ticket #821 (defect)

Opened 3 months ago

Last modified 3 months ago

Rename file 'cherrypy/test/static/has space.htm' to 'cherrypy/test/static/has_space.htm'

Status: closed (fixed)

Reported by: guest Assigned to: fumanchu
Priority: lowest Milestone: 2.3
Component: CherryPy code Keywords:
Cc:

After building and installing (I did this via the Turbogears easy_install), there existed a file 'has space.htm'

# ls CherryPy-2.3.0-py2.5.egg/cherrypy/test/static/
dirback.jpg     has space.html  index.html

The presence of a space ' ' character in the filename:

  1. Broke an in-house script.
  2. Does not conform with cherrypy filename style so far as I can see.
  3. Is in general bad style.

Perhaps it should be changed to the name 'has_space.htm'.

Change History

06/06/08 17:59:36: Modified by fumanchu

  • status changed from new to assigned.
  • milestone set to 3.1.

No; it exists to test serving files which have spaces in the filename. If it's a problem, the test should create it dynamically at test time rather than distribute a static copy.

06/08/08 16:40:26: Modified by fumanchu

  • status changed from assigned to closed.
  • resolution set to fixed.
  • milestone changed from 3.1 to 2.3.

Looks like someone beat me to it in trunk; backported to the 2.x line in [1979].

Hosted by WebFaction

Log in as guest/cpguest to create tickets