Download Install Tutorial Docs FAQ Tools WikiLicense Team IRC Planet Involvement Shop Book

Ticket #509 (defect)

Opened 2 years ago

Last modified 2 years ago

Remove cache filter from CherryPy

Status: closed (fixed)

Reported by: lawouach Assigned to: rdelon
Priority: normal Milestone: 3.0
Component: CherryPy code Keywords:
Cc:

As per message http://groups.google.com/group/cherrypy-devel/browse_thread/thread/4884302c40e3945c, I feel like the cache filter has not its place within CherryPy's core at all. It is confusing and if we settle on the fact Cache cannot be genericly done through different applications then we have to accept the cache filter has no real added value.

We should simply provide it as a third party module as an example.

Change History

04/14/06 01:57:56: Modified by Aamer

Maybe, but we could also limit caching to GET requests and allow others to create their own app-specific cache classes if they want something extra.

04/14/06 18:34:18: Modified by Aamer

Also I wanted to point out that if this filter is removed, it makes caching a more complex problem for Windows users running IIS. *nix users can easiy use Squid, but there's no offical Windows port.

Let's consider making caching limited to GET requests rather than take the large step of completely removing it from the core.

06/08/06 00:34:25: Modified by fumanchu

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [1127]. Caching in CP 3 causes POST, PUT, DELETE to invalidate the cache by default. Set different invalidating methods via the config entry tools.caching.invalid_methods. Note that, if e.g. a POST request is given to a certain URL, this will invalidate the cache for the next GET request. This seems to be the spirit of http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.10.

12/09/06 16:51:40: Modified by fumanchu

  • description changed.

2.x backport provided in [1494]. While doing that, I re-read the spec and noticed that the test was wrong: POST, PUT, and DELETE should not simply be ignored, they should actively invalidate (delete) the cached resource. Fixed that in [1494] as well, and then in trunk in [1495].

Hosted by WebFaction

Log in as guest/cpguest to create tickets