Download Install Tutorial Docs FAQ Tools WikiLicense Team IRC Planet Involvement Shop Book

Changeset 869

Show
Ignore:
Timestamp:
12/13/05 03:20:15
Author:
rdelon
Message:

More PEP 8 in session_authenticatr_filter

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/cherrypy/filters/sessionauthenticatefilter.py

    r867 r869  
    33 
    44 
    5 def defaultLoginScreen(from_page, login = '', errorMsg = ''): 
     5def default_login_screen(from_page, login = '', error_msg = ''): 
    66    return """ 
    77    <html><body> 
     
    1414        </form> 
    1515    </body></html> 
    16     """ % (errorMsg, login, from_page) 
     16    """ % (error_msg, login, from_page) 
    1717 
    18 def defaultCheckLoginAndPassword(login, password): 
    19     # Dummy checkLoginAndPassword function 
     18def default_check_login_and_password(login, password): 
     19    # Dummy check_login_and_password function 
    2020    if login != 'login' or password != 'password': 
    2121        return u'Wrong login/password' 
     
    3232            return 
    3333         
    34         checkLoginAndPassword = cherrypy.config.get('session_authenticate_filter.check_login_and_password', defaultCheckLoginAndPassword) 
    35         loginScreen = cherrypy.config.get('session_authenticate_filter.login_screen', defaultLoginScreen) 
    36         notLoggedIn = cherrypy.config.get('session_authenticate_filter.not_logged_in') 
    37         loadUserByUsername = cherrypy.config.get('session_authenticate_filter.load_user_by_username') 
    38         sessionKey = cherrypy.config.get('session_authenticate_filter.session_key', 'username') 
     34        check_login_and_password = cherrypy.config.get('session_authenticate_filter.check_login_and_password', default_check_login_and_password) 
     35        login_screen = cherrypy.config.get('session_authenticate_filter.login_screen', default_login_screen) 
     36        not_logged_in = cherrypy.config.get('session_authenticate_filter.not_logged_in') 
     37        load_user_by_username = cherrypy.config.get('session_authenticate_filter.load_user_by_username') 
     38        session_key = cherrypy.config.get('session_authenticate_filter.session_key', 'username') 
    3939 
    40         if cherrypy.request.path.endswith('loginScreen'): 
     40        if cherrypy.request.path.endswith('login_screen'): 
    4141            return 
    4242        elif cherrypy.request.path.endswith('do_logout'): 
    43             cherrypy.session[sessionKey] = None 
     43            cherrypy.session[session_key] = None 
    4444            cherrypy.request.user = None 
    4545            from_page = cherrypy.request.params.get('from_page', '..') 
     
    4949            login = cherrypy.request.params['login'] 
    5050            password = cherrypy.request.params['password'] 
    51             errorMsg = checkLoginAndPassword(login, password) 
    52             if errorMsg: 
    53                 cherrypy.response.body = loginScreen(from_page, login = login, errorMsg = errorMsg) 
     51            error_msg = check_login_and_password(login, password) 
     52            if error_msg: 
     53                cherrypy.response.body = login_screen(from_page, login = login, error_msg = error_msg) 
    5454                cherrypy.request.executeMain = False 
    5555            else: 
    56                 cherrypy.session[sessionKey] = login 
     56                cherrypy.session[session_key] = login 
    5757                if not from_page: 
    5858                    from_page = '/' 
     
    6161 
    6262        # Check if user is logged in 
    63         if (not cherrypy.session.get(sessionKey)) and notLoggedIn: 
    64             # Call notLoggedIn so that applications where anynymous user 
     63        if (not cherrypy.session.get(session_key)) and not_logged_in: 
     64            # Call not_logged_in so that applications where anynymous user 
    6565            #   is OK can handle it 
    66             notLoggedIn() 
    67         if not cherrypy.session.get(sessionKey): 
    68             cherrypy.response.body = loginScreen(cherrypy.request.browser_url) 
     66            not_logged_in() 
     67        if not cherrypy.session.get(session_key): 
     68            cherrypy.response.body = login_screen(cherrypy.request.browser_url) 
    6969            cherrypy.request.executeMain = False 
    7070            return 
    7171         
    7272        # Everything is OK: user is logged in 
    73         if loadUserByUsername: 
    74             username = cherrypy.session[sessionKey] 
    75             cherrypy.request.user = loadUserByUsername(username) 
    76             cherrypy.thread_data.user = loadUserByUsername(username) 
     73        if load_user_by_username: 
     74            username = cherrypy.session[session_key] 
     75            cherrypy.request.user = load_user_by_username(username) 
     76            cherrypy.thread_data.user = load_user_by_username(username) 

Hosted by WebFaction

Log in as guest/cpguest to create tickets