Changeset 2019

Timestamp:

07/09/08 15:20:48

Author:

nick125

Message:

Added a unit test, fixed an issue in the core unittest with ipv6-enabled systems and fixed an issue in parseRequestLine() when URL paths contained spaces (or anything that would split on a space)

* Added a encoded URL unittest to test/test_core.py
* Fixed lib/httptools.py's parseRequestLine() to not barf when the request line did not unpack to three values (i.e., if the path contained spaces)
* Fixed the logging test in test_core.py to fix an issue where the logger would log ipv6 addresses.

Files:

• branches/cherrypy-2.x/cherrypy/lib/httptools.py (modified) (1 diff)
• branches/cherrypy-2.x/cherrypy/test/test_core.py (modified) (4 diffs)

branches/cherrypy-2.x/cherrypy/lib/httptools.py

@@ -318 +318 @@
-def parseRequestLine(requestLine):
-    """Return (method, path, querystring, protocol) from a requestLine."""
-
-
+
+
+
+
-    # path may be an abs_path (including "http://host.domain.tld");
-    # Ignore scheme, location, and fragments (so config lookups work).

branches/cherrypy-2.x/cherrypy/test/test_core.py

@@ -328 +328 @@
-    cherrypy.root.divorce = Divorce()
-
+    class Encoded:
+        def default(self, *args):
+            return "Encoded response"
+        default.exposed = True
+
+    cherrypy.root.encoded = Encoded()
-
-    class Cookies(Test):
@@ -464 +470 @@
-        
-        data = open(log_access_file, "rb").readlines()
-
+
+
+
+
-        haslength = False
-        for k, v in self.headers:
@@ -476 +485 @@
-                                          % self.prefix()))
-        
-
+
+
+
+
-        haslength = False
-        for k, v in self.headers:
@@ -933 +945 @@
-        self.assertEqual(results, ["None"] * 20)
-    
+    def testEncodedURL(self):
+        self.getPage('/encoded/%0Ax')
+        self.assertBody("Encoded response")
+
-    def testDefaultContentType(self):
-        self.getPage('/')