Changeset 1775

Timestamp:

10/27/07 12:23:47

Author:

fumanchu

Message:

2.x fix for #744 (Malicious cookies may allow access to files outside the session directory).

Files:

• branches/cherrypy-2.x/cherrypy/filters/sessionfilter.py (modified) (1 diff)

branches/cherrypy-2.x/cherrypy/filters/sessionfilter.py

@@ -348 +348 @@
-        fileName = self.SESSION_PREFIX + id
-        file_path = os.path.join(storage_path, fileName)
+        if not os.path.normpath(file_path).startswith(storage_path):
+            raise cherrypy.HTTPError(400, "Invalid session id in cookie.")
-        return file_path
-